Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the Optimised Media Uploads feature. #3467

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Enable the Optimised Media Uploads feature. #3467

merged 6 commits into from
Oct 31, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 30, 2024 •
edited
Loading

This PR moves the toggle from Developer Options into Advanced Settings, updates the AnalyticsEvents package and tracks user interaction with the toggle. Closes #3398.

3E211222-0FF8-447E-A832-53DB4F582464

@pixlwave pixlwave requested a review from a team as a code owner October 30, 2024 12:07
@pixlwave pixlwave requested review from Velin92 and removed request for a team October 30, 2024 12:07
@pixlwave pixlwave added the pr-feature for a new feature label Oct 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 30, 2024 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 47b2801

@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
848 1 847 0
View the top 1 failed tests by shortest run time 
PreviewTests test_serverSelection()
Stack Traces | 5.36s run time 
failed - Snapshot does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_serverSelection-iPhone-16-en-GB.3.png"
@+
"file:.../tmp/PreviewTests/test_serverSelection-iPhone-16-en-GB.3.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.91864014 is less than required 1.0
The lowest perceptual color precision 0.29250002 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@pixlwave
Enable the Optimised Media Uploads feature.
6954d23 
(Well move the toggle from Developer Options to Advanced Settings)
@pixlwave
Add OptimizeMediaUploads analytics.
417c637
@pixlwave
Final strings.
9add624
@pixlwave
Upload reduced quality media by default 😢
57acffc 
Move the setting out of the feature flags section in the file.
@pixlwave pixlwave force-pushed the doug/enable-optimised-media branch from 0e493ec to 57acffc Compare October 31, 2024 09:43
@pixlwave pixlwave requested review from manuroe and removed request for Velin92 October 31, 2024 10:23
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

manuroe
manuroe approved these changes Oct 31, 2024
View reviewed changes
ElementX/Sources/Screens/Settings/AvancedOptionsScreen/AdvancedSettingsScreenViewModel.swift
override func process(viewAction: AdvancedSettingsScreenViewAction) {
switch viewAction {
case .optimizeMediaUploadsChanged:
// Note: Using a view action here as sinking the AppSettings publisher tracks the initial value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pixlwave pixlwave merged commit 1f90f1a into develop Oct 31, 2024
7 checks passed
@pixlwave pixlwave deleted the doug/enable-optimised-media branch October 31, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuroe manuroe manuroe approved these changes

Assignees
No one assigned
Labels
pr-feature for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Resize media before sending
2 participants
@pixlwave @manuroe